fix(测试数据生成器): 修复 Worker 取消失效与规则存储静默失败

- 为生成任务引入 generationId,忽略过期 Worker 响应,避免取消后展示错误数据
- Worker 每 100 行让出事件循环,使 cancel 消息能被及时处理
- ruleStorage.setAll 返回写入结果,save/update/delete 在 QuotaExceeded 时返回失败
- 补充 useGenerator 与 ruleStorage 单元测试
This commit is contained in:
Cursor Agent
2026-06-26 08:41:32 +00:00
parent a163297de4
commit 42ab669d5f
6 changed files with 262 additions and 25 deletions
@@ -0,0 +1,117 @@
import { act, renderHook, waitFor } from '@testing-library/react';
import { beforeEach, describe, expect, it, vi } from 'vitest';
import { useGenerator } from '@/pages/TestDataGenerator/hooks/useGenerator';
import type { FieldConfig, WorkerResponseMessage } from '@/types/testDataGenerator';
const mockField: FieldConfig = {
id: 'field-1',
name: 'username',
generatorId: 'string',
params: {},
required: true,
nullRate: 0,
unique: false,
};
type WorkerListener = (event: MessageEvent<WorkerResponseMessage>) => void;
class MockWorker {
static instances: MockWorker[] = [];
onmessage: WorkerListener | null = null;
onerror: ((event: ErrorEvent) => void) | null = null;
postedMessages: unknown[] = [];
constructor(_url: URL, _options?: WorkerOptions) {
MockWorker.instances.push(this);
}
postMessage(message: unknown) {
this.postedMessages.push(message);
}
terminate() {
const index = MockWorker.instances.indexOf(this);
if (index >= 0) {
MockWorker.instances.splice(index, 1);
}
}
emit(message: WorkerResponseMessage) {
this.onmessage?.({ data: message } as MessageEvent<WorkerResponseMessage>);
}
}
describe('useGenerator', () => {
beforeEach(() => {
MockWorker.instances = [];
vi.stubGlobal('Worker', MockWorker);
});
it('应忽略过期 generationId 的 complete 消息', async () => {
const { result } = renderHook(() => useGenerator());
act(() => {
result.current.generate([mockField], 10);
});
const worker = MockWorker.instances[0];
expect(worker).toBeDefined();
act(() => {
result.current.cancel();
});
act(() => {
result.current.generate([mockField], 5);
});
act(() => {
worker.emit({
type: 'complete',
generationId: 1,
payload: {
success: true,
data: [{ username: 'stale' }],
stats: { total: 10, success: 10, failed: 0, duration: 1 },
},
});
});
expect(result.current.result).toBeNull();
expect(result.current.isGenerating).toBe(true);
act(() => {
worker.emit({
type: 'complete',
generationId: 3,
payload: {
success: true,
data: [{ username: 'fresh' }],
stats: { total: 5, success: 5, failed: 0, duration: 1 },
},
});
});
await waitFor(() => {
expect(result.current.isGenerating).toBe(false);
});
expect(result.current.result?.data?.[0]).toEqual({ username: 'fresh' });
});
it('cancel 后应发送 cancel 消息并使 generationId 失效', () => {
const { result } = renderHook(() => useGenerator());
act(() => {
result.current.generate([mockField], 100);
});
const worker = MockWorker.instances[0];
act(() => {
result.current.cancel();
});
expect(result.current.isGenerating).toBe(false);
expect(worker.postedMessages).toEqual(expect.arrayContaining([{ type: 'cancel' }]));
});
});
@@ -8,7 +8,8 @@ import type {
FieldConfig, FieldConfig,
GenerateResult, GenerateResult,
GenerateProgress, GenerateProgress,
WorkerMessage, WorkerRequestMessage,
WorkerResponseMessage,
} from '@/types/testDataGenerator'; } from '@/types/testDataGenerator';
export interface UseGeneratorReturn { export interface UseGeneratorReturn {
@@ -35,6 +36,7 @@ export function useGenerator(): UseGeneratorReturn {
const [error, setError] = useState<string | null>(null); const [error, setError] = useState<string | null>(null);
const workerRef = useRef<Worker | null>(null); const workerRef = useRef<Worker | null>(null);
const generationIdRef = useRef(0);
// 清理 Worker // 清理 Worker
useEffect(() => { useEffect(() => {
@@ -58,22 +60,30 @@ export function useGenerator(): UseGeneratorReturn {
type: 'module', type: 'module',
}); });
worker.onmessage = (e: MessageEvent<WorkerMessage>) => { worker.onmessage = (e: MessageEvent<WorkerResponseMessage>) => {
const data = e.data; const data = e.data;
const { type } = data; const { type } = data;
if (data.generationId !== generationIdRef.current) {
return;
}
switch (type) { switch (type) {
case 'progress': case 'progress':
setProgress(data.payload as GenerateProgress); setProgress(data.payload);
break; break;
case 'complete': case 'complete':
setIsGenerating(false); setIsGenerating(false);
setResult(data.payload as GenerateResult); if (data.payload.success) {
setResult(data.payload);
} else if (data.payload.error && data.payload.error !== '生成已取消') {
setError(data.payload.error);
}
setProgress(null); setProgress(null);
break; break;
case 'error': case 'error':
setIsGenerating(false); setIsGenerating(false);
setError((data.payload as { error: string }).error); setError(data.payload.error);
setProgress(null); setProgress(null);
break; break;
} }
@@ -100,15 +110,17 @@ export function useGenerator(): UseGeneratorReturn {
(fields: FieldConfig[], count: number, csvMode = false) => { (fields: FieldConfig[], count: number, csvMode = false) => {
if (isGenerating) return; if (isGenerating) return;
const generationId = ++generationIdRef.current;
setIsGenerating(true); setIsGenerating(true);
setProgress(null); setProgress(null);
setResult(null); setResult(null);
setError(null); setError(null);
const worker = getWorker(); const worker = getWorker();
const message: WorkerMessage = { const message: WorkerRequestMessage = {
type: 'start', type: 'start',
payload: { fields, count, csvMode }, payload: { generationId, fields, count, csvMode },
}; };
worker.postMessage(message); worker.postMessage(message);
}, },
@@ -120,7 +132,8 @@ export function useGenerator(): UseGeneratorReturn {
*/ */
const cancel = useCallback(() => { const cancel = useCallback(() => {
if (workerRef.current && isGenerating) { if (workerRef.current && isGenerating) {
const message: WorkerMessage = { type: 'cancel' }; ++generationIdRef.current;
const message: WorkerRequestMessage = { type: 'cancel' };
workerRef.current.postMessage(message); workerRef.current.postMessage(message);
setIsGenerating(false); setIsGenerating(false);
setProgress(null); setProgress(null);
+15 -5
View File
@@ -156,19 +156,29 @@ export interface GenerateProgress {
} }
/** /**
* Worker 消息类型 * Worker 请求消息类型
*/ */
export type WorkerMessage = export type WorkerRequestMessage =
| { type: 'start'; payload: WorkerStartPayload } | { type: 'start'; payload: WorkerStartPayload }
| { type: 'progress'; payload: GenerateProgress }
| { type: 'complete'; payload: GenerateResult }
| { type: 'error'; payload: { error: string } }
| { type: 'cancel' }; | { type: 'cancel' };
/**
* Worker 响应消息类型
*/
export type WorkerResponseMessage =
| { type: 'progress'; generationId: number; payload: GenerateProgress }
| { type: 'complete'; generationId: number; payload: GenerateResult }
| { type: 'error'; generationId: number; payload: { error: string } };
/** @deprecated 使用 WorkerRequestMessage | WorkerResponseMessage */
export type WorkerMessage = WorkerRequestMessage | WorkerResponseMessage;
/** /**
* Worker 启动参数 * Worker 启动参数
*/ */
export interface WorkerStartPayload { export interface WorkerStartPayload {
/** 生成任务 ID,用于忽略过期 Worker 响应 */
generationId: number;
/** 字段配置列表 */ /** 字段配置列表 */
fields: FieldConfig[]; fields: FieldConfig[];
/** 生成数量 */ /** 生成数量 */
+65
View File
@@ -0,0 +1,65 @@
import { beforeEach, describe, expect, it, vi } from 'vitest';
import * as ruleStorage from '../ruleStorage';
const STORAGE_KEY = 'testDataGenerator_rules';
const mockField = {
id: 'field-1',
name: 'username',
generatorId: 'string',
params: {},
required: true,
nullRate: 0,
unique: false,
};
describe('ruleStorage', () => {
beforeEach(() => {
localStorage.clear();
vi.restoreAllMocks();
});
it('save 在 localStorage 写入失败时应返回 null', () => {
vi.spyOn(Storage.prototype, 'setItem').mockImplementation(() => {
throw new DOMException('QuotaExceededError');
});
const result = ruleStorage.save({
name: 'Test Rule',
fields: [mockField],
});
expect(result).toBeNull();
expect(localStorage.getItem(STORAGE_KEY)).toBeNull();
});
it('update 在 localStorage 写入失败时应返回 null', () => {
const saved = ruleStorage.save({
name: 'Test Rule',
fields: [mockField],
});
expect(saved).not.toBeNull();
vi.spyOn(Storage.prototype, 'setItem').mockImplementation(() => {
throw new DOMException('QuotaExceededError');
});
const updated = ruleStorage.update(saved!.id, { name: 'Updated Rule' });
expect(updated).toBeNull();
});
it('deleteRule 在 localStorage 写入失败时应返回 false', () => {
const saved = ruleStorage.save({
name: 'Test Rule',
fields: [mockField],
});
expect(saved).not.toBeNull();
vi.spyOn(Storage.prototype, 'setItem').mockImplementation(() => {
throw new DOMException('QuotaExceededError');
});
expect(ruleStorage.deleteRule(saved!.id)).toBe(false);
expect(ruleStorage.getById(saved!.id)).toBeDefined();
});
});
+16 -7
View File
@@ -78,7 +78,9 @@ export function save(
useCount: 0, useCount: 0,
}; };
rules.unshift(newRule); rules.unshift(newRule);
setAll(rules); if (!setAll(rules)) {
return null;
}
return newRule; return newRule;
} }
@@ -95,7 +97,9 @@ export function save(
updatedAt: now, updatedAt: now,
}; };
rules[index] = updatedRule; rules[index] = updatedRule;
setAll(rules); if (!setAll(rules)) {
return null;
}
return updatedRule; return updatedRule;
} }
@@ -117,7 +121,9 @@ export function update(id: string, updates: Partial<DataRule>): DataRule | null
updatedAt: Date.now(), updatedAt: Date.now(),
}; };
rules[index] = updatedRule; rules[index] = updatedRule;
setAll(rules); if (!setAll(rules)) {
return null;
}
return updatedRule; return updatedRule;
} }
@@ -132,8 +138,7 @@ export function deleteRule(id: string): boolean {
return false; return false;
} }
rules.splice(index, 1); rules.splice(index, 1);
setAll(rules); return setAll(rules);
return true;
} }
/** /**
@@ -165,7 +170,9 @@ export function duplicate(id: string, copySuffix = '(副本)'): DataRule | n
const rules = getAll(); const rules = getAll();
rules.unshift(newRule); rules.unshift(newRule);
setAll(rules); if (!setAll(rules)) {
return null;
}
return newRule; return newRule;
} }
@@ -267,11 +274,13 @@ export function clear(): void {
/** /**
* 保存所有规则到存储 * 保存所有规则到存储
*/ */
function setAll(rules: DataRule[]): void { function setAll(rules: DataRule[]): boolean {
try { try {
localStorage.setItem(STORAGE_KEY, JSON.stringify(rules)); localStorage.setItem(STORAGE_KEY, JSON.stringify(rules));
return true;
} catch (error) { } catch (error) {
console.error('[ruleStorage] 保存规则失败:', error); console.error('[ruleStorage] 保存规则失败:', error);
return false;
} }
} }
+28 -5
View File
@@ -6,11 +6,14 @@
import { getGeneratorById } from '@/lib/generators'; import { getGeneratorById } from '@/lib/generators';
import type { import type {
FieldConfig, FieldConfig,
WorkerMessage, WorkerRequestMessage,
GenerateResult, GenerateResult,
GenerateProgress, GenerateProgress,
} from '@/types/testDataGenerator'; } from '@/types/testDataGenerator';
/** 每生成 N 行让出一次事件循环,以便处理 cancel 消息 */
const YIELD_EVERY = 100;
// 生成结果缓存 // 生成结果缓存
let generatedData: Record<string, unknown>[] = []; let generatedData: Record<string, unknown>[] = [];
let isCancelled = false; let isCancelled = false;
@@ -18,7 +21,7 @@ let isCancelled = false;
/** /**
* Worker 消息处理器 * Worker 消息处理器
*/ */
self.onmessage = async (e: MessageEvent<WorkerMessage>) => { self.onmessage = async (e: MessageEvent<WorkerRequestMessage>) => {
const data = e.data; const data = e.data;
const { type } = data; const { type } = data;
@@ -37,11 +40,12 @@ self.onmessage = async (e: MessageEvent<WorkerMessage>) => {
* 处理开始生成消息 * 处理开始生成消息
*/ */
async function handleStart(payload: { async function handleStart(payload: {
generationId: number;
fields: FieldConfig[]; fields: FieldConfig[];
count: number; count: number;
csvMode: boolean; csvMode: boolean;
}): Promise<void> { }): Promise<void> {
const { fields, count } = payload; const { generationId, fields, count } = payload;
generatedData = []; generatedData = [];
try { try {
@@ -51,6 +55,7 @@ async function handleStart(payload: {
if (!generator) { if (!generator) {
self.postMessage({ self.postMessage({
type: 'error', type: 'error',
generationId,
payload: { error: `生成器 "${field.generatorId}" 不存在` }, payload: { error: `生成器 "${field.generatorId}" 不存在` },
}); });
return; return;
@@ -65,6 +70,7 @@ async function handleStart(payload: {
if (isCancelled) { if (isCancelled) {
self.postMessage({ self.postMessage({
type: 'complete', type: 'complete',
generationId,
payload: { payload: {
success: false, success: false,
error: '生成已取消', error: '生成已取消',
@@ -136,7 +142,23 @@ async function handleStart(payload: {
total: count, total: count,
estimatedTimeLeft: Math.round(((Date.now() - startTime) / (i + 1)) * (count - i - 1)), estimatedTimeLeft: Math.round(((Date.now() - startTime) / (i + 1)) * (count - i - 1)),
}; };
self.postMessage({ type: 'progress', payload: progress }); self.postMessage({ type: 'progress', generationId, payload: progress });
}
// 定期让出事件循环,使 cancel 消息能被处理
if ((i + 1) % YIELD_EVERY === 0) {
await new Promise<void>((resolve) => setTimeout(resolve, 0));
if (isCancelled) {
self.postMessage({
type: 'complete',
generationId,
payload: {
success: false,
error: '生成已取消',
},
});
return;
}
} }
} }
@@ -155,10 +177,11 @@ async function handleStart(payload: {
}, },
}; };
self.postMessage({ type: 'complete', payload: result }); self.postMessage({ type: 'complete', generationId, payload: result });
} catch (error) { } catch (error) {
self.postMessage({ self.postMessage({
type: 'error', type: 'error',
generationId,
payload: { error: `生成失败: ${error}` }, payload: { error: `生成失败: ${error}` },
}); });
} }